[PATCH] D71127: [ARM] Add custom strict fp conversion lowering when non-strict is custom

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks

I would prefer if there were some tests in here. I looked at that file though, just running the update script on it. There are a lot of pushes and pops and softfloat movs and conflicting asms and whatnot. Perhaps you are right that is makes it more complex than would be good for it. (But.. I always dislike tests that just say `; CHECK-SP: vcvt.s32.f32`, it is so easy to miss poor codegen. There could be a thousand instructions around that vcvt!)

As we know the test will be enabled later, and at this point I have certainly ran it enough to know this works, LGTM. If you want to improve the test (now or later), that's great. If you don't want to, I'm not going to be stubborn about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71127/new/

https://reviews.llvm.org/D71127