[PATCH] D71442: [X86] Check if source elements are not structures before using a uniform base for the Gather/Scatter intrinsic.
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 12 23:28:52 PST 2019
pengfei marked an inline comment as done.
pengfei added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4380
+ // FIXME: It seems there's a bug here. SDB->findValue(Ptr) seems always
+ // return true. SDB->findValue(IndexVal) always false unless the same
+ // constant happen to present in unrelated IRs.
----------------
craig.topper wrote:
> craig.topper wrote:
> > What is IndexVal isn't a constant?
> What if IndexVal isn't a constant?
Makes sence.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71442/new/
https://reviews.llvm.org/D71442
More information about the llvm-commits
mailing list