[PATCH] D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2)

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Driver.cpp:538
+    std::error_code errorCode;
+    raw_fd_ostream profilerOS(path, errorCode, sys::fs::F_Text);
+    if (errorCode) {
----------------
OF_Text. F_Text is for compatibility only.


================
Comment at: lld/test/ELF/check-time-trace.s:1
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
----------------
Just `time-trace.s`?


================
Comment at: lld/test/ELF/check-time-trace.s:2
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+
----------------
Delete `-unknown-linux`


================
Comment at: lld/test/ELF/check-time-trace.s:23
+# Check one event has correct fields
+# CHECK: "dur":
+# CHECK-NEXT: "name":
----------------
Align keys. See other files (with a llvm-readobj RUN line) for examples


================
Comment at: llvm/include/llvm/LTO/Config.h:120
 
+  /// Time trace enabled
+  bool TimeTraceEnabled = false;
----------------
Full stop


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71060/new/

https://reviews.llvm.org/D71060