[PATCH] D71394: llvm-objdump should ignore Mach-O stab symbols for disassembly.

[Michael Trent via Phabricator via llvm-commits]

mtrent marked an inline comment as done.
mtrent added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1152
 
+    // Don't ask a MachO STAB for its section unless you know that STAB has a
+    // section, because a STAB section might not actually be a section. 
----------------
MaskRay wrote:
> I think that this comment could be clearer.
> 
> Does this comment suggest that the reader should skip this piece of code if they don't know what a STAB section is? (I don't know what a STAB section is.)
“Don’t ask a Mach-O STAB symbol for its section unless you know the STAB symbol section field refers to a section index. Otherwise SymbolRef may error trying to load a section that does not exist.” ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71394/new/

https://reviews.llvm.org/D71394