[PATCH] D71144: Not emit correct Assembly for Global Function pointer initiated with function.
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 12 15:35:48 PST 2019
hubert.reinterpretcast added a comment.
The commit subject should be more direct in indicating what the patch does, not what problem it solves.
The message body reads too much like a problem report.
Suggestion:
> [AIX] Use csect reference for function address constants
>
> We currently emit a reference for function address constants as labels;
> for example:
>
> foo_ptr:
> .long foo
>
>
> however, there may be no such label in the case where the function is
> undefined. Although the label exists when the function is defined, we
> will (to be consistent) also use a csect reference in that case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71144/new/
https://reviews.llvm.org/D71144
More information about the llvm-commits
mailing list