[PATCH] D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

This seems to be in good shape overall and the SelectionDAG changes look reasonable. I don't intend my comments here to block committing.



================
Comment at: llvm/test/DebugInfo/X86/dbg-value-dropped-instcombine.ll:26
+
+; CHECK: @llvm.dbg.value({{.*}}, metadata ![[BEE]], metadata !DIExpression({{.*}}, DW_OP_LLVM_fragment, 32, 32)),
 
----------------
This looks like it would have matched before this patch. Consider `; CHECK: @llvm.dbg.value(metadata i32 %{{.*}},`?


================
Comment at: llvm/test/Transforms/InstCombine/pr43893.ll:16
   %conv = sext i8 %dec to i32, !dbg !17
-  call void @llvm.dbg.value(metadata i32 %conv, metadata !18, metadata !DIExpression()), !dbg !19
+  %udiv = udiv i32 %conv, 4, !dbg !17
+  call void @llvm.dbg.value(metadata i32 %udiv, metadata !18, metadata !DIExpression()), !dbg !19
----------------
I'm not sure I understand this change. Why is the dbg.value for %conv deleted?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61184/new/

https://reviews.llvm.org/D61184