[PATCH] D71426: [ARM] Utility functions MVEOpcodes. NFC.

Thu Dec 12 10:14:42 PST 2019

samparker added a comment.

Do we need a cpp file..? Would be nice for these helpers to get inlined. Yaybe worth them living in ARMBaseInstrInfo.h as there's already a VPT opcode helper there too.

================
Comment at: llvm/lib/Target/ARM/Utils/MVEOpcodes.cpp:17
+
+Intrinsic::ID getVCTPInstricID(int NumElements) {
+  switch (NumElements) {
----------------
This is only really ever going to be used in one place so I'd prefer it stay there really.

================
Comment at: llvm/lib/Target/ARM/Utils/MVEOpcodes.cpp:115
+
+bool IsLoopStart(unsigned Opcode) {
+  return Opcode == ARM::t2DoLoopStart ||
----------------
These aren't MVE instructions.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71426/new/

https://reviews.llvm.org/D71426