[PATCH] D71344: [llvm-dwarfdump] Add blank line after printing line table

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 12 06:10:15 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rG84a9756a72d8: [llvm-dwarfdump] Add blank line after printing line table (authored by jhenderson).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71344/new/

https://reviews.llvm.org/D71344

Files:
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/tools/llvm-dwarfdump/X86/debug-line.s


Index: llvm/test/tools/llvm-dwarfdump/X86/debug-line.s
===================================================================
--- llvm/test/tools/llvm-dwarfdump/X86/debug-line.s
+++ llvm/test/tools/llvm-dwarfdump/X86/debug-line.s
@@ -43,6 +43,7 @@
 # CHECK-NEXT: 0x0000000000000002      1      0      1   0             0  is_stmt
 # CHECK-NEXT: 0x0000000000000002      1      4      3   0             0  is_stmt
 # CHECK-NEXT: 0x0000000000000024      1      4      3   5             6  basic_block prologue_end epilogue_begin end_sequence
+# CHECK-EMPTY:
 # CHECK-NEXT: debug_line[0x0000006d]
 # CHECK-NEXT: Line table prologue:
 # CHECK-NEXT:     total_length: 0x0000001b
Index: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
===================================================================
--- llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
+++ llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
@@ -461,6 +461,10 @@
       R.dump(OS);
     }
   }
+
+  // Terminate the table with a final blank line to clearly delineate it from
+  // later dumps.
+  OS << '\n';
 }
 
 void DWARFDebugLine::LineTable::clear() {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71344.233602.patch
Type: text/x-patch
Size: 1100 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191212/154139ec/attachment.bin>


More information about the llvm-commits mailing list