[llvm] 4ecf255 - [Attributor][NFC] Fix comments and unnecessary comma
Hideto Ueno via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 12 05:45:47 PST 2019
Author: Hideto Ueno
Date: 2019-12-12T13:42:40Z
New Revision: 4ecf25545c3b34eb5a74ce920e421e59aab94905
URL: https://github.com/llvm/llvm-project/commit/4ecf25545c3b34eb5a74ce920e421e59aab94905
DIFF: https://github.com/llvm/llvm-project/commit/4ecf25545c3b34eb5a74ce920e421e59aab94905.diff
LOG: [Attributor][NFC] Fix comments and unnecessary comma
Added:
Modified:
llvm/include/llvm/Transforms/IPO/Attributor.h
llvm/lib/Transforms/IPO/Attributor.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/Transforms/IPO/Attributor.h b/llvm/include/llvm/Transforms/IPO/Attributor.h
index 4f6f823a230b..bacbccda02c6 100644
--- a/llvm/include/llvm/Transforms/IPO/Attributor.h
+++ b/llvm/include/llvm/Transforms/IPO/Attributor.h
@@ -1840,7 +1840,9 @@ struct DerefState : AbstractState {
/// ```
/// In that case, AccessedBytesMap is `{0:4, 4:4, 8:4, 40:4}`.
/// AccessedBytesMap is std::map so it is iterated in accending order on
- /// key(Offset). So KnownBytes will be updated like this: |Access | KnownBytes
+ /// key(Offset). So KnownBytes will be updated like this:
+ ///
+ /// |Access | KnownBytes
/// |(0, 4)| 0 -> 4
/// |(4, 4)| 4 -> 8
/// |(8, 4)| 8 -> 12
diff --git a/llvm/lib/Transforms/IPO/Attributor.cpp b/llvm/lib/Transforms/IPO/Attributor.cpp
index f43c02c4495b..305cc2898230 100644
--- a/llvm/lib/Transforms/IPO/Attributor.cpp
+++ b/llvm/lib/Transforms/IPO/Attributor.cpp
@@ -1564,7 +1564,7 @@ struct AANoFreeFloating : AANoFreeImpl {
isa<PHINode>(UserI) || isa<SelectInst>(UserI)) {
Follow = true;
return true;
- };
+ }
// Unknown user.
return false;
@@ -3254,7 +3254,8 @@ struct AAAlignImpl : AAAlign {
bool followUse(Attributor &A, const Use *U, const Instruction *I) {
bool TrackUse = false;
- unsigned int KnownAlign = getKnownAlignForUse(A, *this, getAssociatedValue(), U, I, TrackUse);
+ unsigned int KnownAlign =
+ getKnownAlignForUse(A, *this, getAssociatedValue(), U, I, TrackUse);
takeKnownMaximum(KnownAlign);
return TrackUse;
@@ -3950,14 +3951,14 @@ struct AAValueSimplifyArgument final : AAValueSimplifyImpl {
// callback calls).
Value *ArgOp = ACS.getCallArgOperand(getArgNo());
if (!ArgOp)
- return false;
+ return false;
// We can only propagate thread independent values through callbacks.
// This is
diff erent to direct/indirect call sites because for them we
// know the thread executing the caller and callee is the same. For
// callbacks this is not guaranteed, thus a thread dependent value could
// be
diff erent for the caller and callee, making it invalid to propagate.
if (ACS.isCallbackCall())
- if (auto *C =dyn_cast<Constant>(ArgOp))
+ if (auto *C = dyn_cast<Constant>(ArgOp))
if (C->isThreadDependent())
return false;
return checkAndUpdate(A, *this, *ArgOp, SimplifiedAssociatedValue);
@@ -5558,8 +5559,8 @@ void Attributor::identifyDefaultAbstractAttributes(Function &F) {
// Call site argument attribute "align".
getOrCreateAAFor<AAAlign>(CSArgPos);
- // Call site argument attribute "nofree".
- getOrCreateAAFor<AANoFree>(CSArgPos);
+ // Call site argument attribute "nofree".
+ getOrCreateAAFor<AANoFree>(CSArgPos);
}
}
return true;
More information about the llvm-commits
mailing list