[PATCH] D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 12 02:37:09 PST 2019


bjope added a comment.

LGTM!
(if removing the unused VarInstPair/InstsToSink)



================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:357
+    using VarInstPair = std::pair<DebugVariable, MachineInstr *>;
+    SmallVector<VarInstPair, 16> InstsToSink;
+    for (auto &SunkLoc : Def.InstsToSink) {
----------------
VarInstPair and InstsToSink are no longer used afaict.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70676/new/

https://reviews.llvm.org/D70676





More information about the llvm-commits mailing list