[PATCH] D67572: [VectorUtils] Introduce the Vector Function Database (VFDatabase).

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

In D67572#1781363 <https://reviews.llvm.org/D67572#1781363>, @fhahn wrote:

> [...]
>
> > Is this change in behavior intended?
>
> This change in behavior sounds a bit worrying for down-stream targets.
>
> I think we should have at least an assertion making sure the check in LoopVEctorizationLegality succeeds in all cases it did previously with isFunctionVectorizable, otherwise down-stream targets will silently miss out on vectorization.


Yes that's exactly what happened to us. Or well, "silently", since our benchmark numbers went crazy after the merge :)

> But I think ideally the patch would preserve the existing behavior in the cases @uabelho  described.

Sounds good!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67572/new/

https://reviews.llvm.org/D67572