[PATCH] D70606: LLD: CET shadow stack support on Windows

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

>> In D70606#1779258 <https://reviews.llvm.org/D70606#1779258>, @jhenderson wrote:
>> 
>>> On this topic, yaml2obj has COFF support, although I don't know if that's sufficient for your use case here.
>> 
>> 
>> `yaml2obj` does not yet have CET flag support. What is the preferred path in this situation? We can add it, but it would be only used in this test.
> 
> I'd prefer enhancing yaml2obj tool so that it can emit the extended characteristics field if it is not too hard.

In general, I'm always in favour of enhancing the tool where possible. Binary files are always opaque and hard to understand what is in them, so yaml2obj should be extended if it's sensible to do so. The more we do that, the less easier future tests will be to write!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70606/new/

https://reviews.llvm.org/D70606