[PATCH] D71385: Update the man page
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 12 00:34:47 PST 2019
ruiu added a comment.
In D71385#1781099 <https://reviews.llvm.org/D71385#1781099>, @grimar wrote:
> A question: do we need to specify the particular compression level in docs? My feeling is that
> belongs to internal implementation, it is not really useful for user to know the level probably?
>
> Imagine if we switch to another zlib implementation, like was suggested in the original PR,
> what if it doesn't have these levels (I do not know if it has).
>
> What would be probably better is to say something like:
> "By default we use a compression, that is fast and effective enough, but if you want to
> reduce the size of debug sections even more, you can specify -O2 to enable more aggressive,
> but slower compression"
I understand your point, but if I were to read your explanation for the first time, I would wonder what the actual compression levels are. People should be familiar with the notion of the compression level by gzip command option -0, ..., -9, and giving the numbers seems to be a most clear way to tell them what lld is doing. The numbers are not promise or anything, we can change that anytime, since they are only for documentation purpose.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71385/new/
https://reviews.llvm.org/D71385
More information about the llvm-commits
mailing list