[compiler-rt] fa0fc04 - Temporarily Revert "[libc++] Fix -Wdeprecated-copy warnings in __bit_reference"

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 12 00:30:09 PST 2019


And I added an extra commit here. I'll revert, reapply the missed fix and
split out the other. Sorry for the noise.

-eric

On Thu, Dec 12, 2019 at 12:22 AM Eric Christopher via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> Author: Eric Christopher
> Date: 2019-12-12T00:22:37-08:00
> New Revision: fa0fc04a4f950461e3f5675487b477c94e456842
>
> URL:
> https://github.com/llvm/llvm-project/commit/fa0fc04a4f950461e3f5675487b477c94e456842
> DIFF:
> https://github.com/llvm/llvm-project/commit/fa0fc04a4f950461e3f5675487b477c94e456842.diff
>
> LOG: Temporarily Revert "[libc++] Fix -Wdeprecated-copy warnings in
> __bit_reference"
> as it's causing test failures due to mismatched visibility.
>
> This reverts commit 02bb20223bda5add729402962c70d0ebd0d98af2.
>
> Added:
>
>
> Modified:
>     compiler-rt/lib/sanitizer_common/scripts/check_lint.sh
>     libcxx/include/__bit_reference
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/compiler-rt/lib/sanitizer_common/scripts/check_lint.sh
> b/compiler-rt/lib/sanitizer_common/scripts/check_lint.sh
> index fdd8de792dbf..8e624f6e6a77 100755
> --- a/compiler-rt/lib/sanitizer_common/scripts/check_lint.sh
> +++ b/compiler-rt/lib/sanitizer_common/scripts/check_lint.sh
> @@ -55,7 +55,7 @@ run_lint() {
>    FILTER=$1
>    shift
>    TASK_LOG=$(${MKTEMP})
> -  ${CPPLINT} --filter=${FILTER} "$@" 2>$TASK_LOG
> +  ${CPPLINT} --quiet --filter=${FILTER} "$@" 2>$TASK_LOG
>    if [ "$?" != "0" ]; then
>      cat $TASK_LOG | grep -v "Done processing" | grep -v "Total errors
> found" \
>        | grep -v "Skipping input" >> $ERROR_LOG
>
> diff  --git a/libcxx/include/__bit_reference
> b/libcxx/include/__bit_reference
> index f035eeae7af5..05dfbe7e9fff 100644
> --- a/libcxx/include/__bit_reference
> +++ b/libcxx/include/__bit_reference
> @@ -62,8 +62,6 @@ public:
>          return *this;
>      }
>
> -    __bit_reference(const __bit_reference&) = default;
> -
>      _LIBCPP_INLINE_VISIBILITY
>      __bit_reference& operator=(const __bit_reference& __x) _NOEXCEPT
>          {return operator=(static_cast<bool>(__x));}
> @@ -150,7 +148,6 @@ private:
>          : __seg_(__s), __mask_(__m) {}
>
>      __bit_const_reference& operator=(const __bit_const_reference& __x);
> -    __bit_const_reference(const __bit_const_reference&) = default;
>  };
>
>  // find
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191212/52dc46b1/attachment.html>


More information about the llvm-commits mailing list