[PATCH] D71367: [AMDGPU] Fold 64 bit immediates

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 20:55:53 PST 2019


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:2954-2958
+  if (MO.isImm()) {
+    int64_t Imm = MO.getImm();
+    if (!isInt<32>(Imm) && !isUInt<32>(Imm))
+      return false;
+  }
----------------
I think this is more complicated and depends on the context instruction, which is why this was never done. I think some instructions zero-extend the 32-bit constants (including FP), and then maybe some sign extend


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71367/new/

https://reviews.llvm.org/D71367





More information about the llvm-commits mailing list