[PATCH] D71391: [PowerPC] Modify the hasSideEffects of some VSX instructions from 1 to 0

Zhang Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 22:25:39 PST 2019


ZhangKang created this revision.
ZhangKang added reviewers: PowerPC, hfinkel.
Herald added subscribers: shchenz, wuzish.
Herald added a project: LLVM.
ZhangKang updated this revision to Diff 233501.
ZhangKang added a comment.

Modify the patch.


If we didn't set the value for hasSideEffects bit in our td file,  `llvm-tblgen` will set it as true for those instructions which has no match pattern. 
Below 6 instructions don't set the hasSideEffects flag and don't have match pattern, so their hasSideEffects flag will be set true by llvm-tblgen.

But in fact below instructions don't modify any special register and don't have other SideEffects, they shouldn't have SideEffects.
This patch is to modify the hasSideEffects of below instructions from 1 to 0.

  VEXTUHLX
  VEXTUHRX
  VEXTUWLX
  VEXTUWRX
  VSPLTBs
  VSPLTHs


https://reviews.llvm.org/D71391

Files:
  llvm/lib/Target/PowerPC/PPCInstrAltivec.td
  llvm/test/CodeGen/PowerPC/pre-inc-disable.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71391.233501.patch
Type: text/x-patch
Size: 6585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191212/82fd530f/attachment.bin>


More information about the llvm-commits mailing list