[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 20:58:15 PST 2019


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:212
   bool UseG0 = false;
+  bool UseLLD = Args.getLastArgValue(options::OPT_fuse_ld_EQ).startswith("lld");
   bool UseShared = IsShared && !IsStatic;
----------------
bcain wrote:
> Does this still work when `-fuse-ld=ld.lld` ?  How about absolute paths `-fuse-ld=/path/to/lld`?
Fuchsia uses:

```
  const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath());
  if (llvm::sys::path::filename(Exec).equals_lower("ld.lld") ||
      llvm::sys::path::stem(Exec).equals_lower("ld.lld")) {
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70919/new/

https://reviews.llvm.org/D70919





More information about the llvm-commits mailing list