[llvm] 70d1425 - Don't call export_symbols.py with duplicate libs

[David Tenty via llvm-commits]

Author: David Tenty
Date: 2019-12-11T17:23:31-05:00
New Revision: 70d14255dfcd9c4849deff9e9f2912c8ec030d11

URL: https://github.com/llvm/llvm-project/commit/70d14255dfcd9c4849deff9e9f2912c8ec030d11
DIFF: https://github.com/llvm/llvm-project/commit/70d14255dfcd9c4849deff9e9f2912c8ec030d11.diff

LOG: Don't call export_symbols.py with duplicate libs

Summary:
export_symbols.py discards duplicate symbols, assuming they have public definitions, so if we end
up calling it with duplicate libraries we will end up with an inaccurate export list.

Reviewers: jasonliu, stevewan, john.brawn

Reviewed By: john.brawn

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70918

Added: 
    

Modified: 
    llvm/cmake/modules/AddLLVM.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/cmake/modules/AddLLVM.cmake b/llvm/cmake/modules/AddLLVM.cmake
index 518ea608d232..34f532c9e455 100644
--- a/llvm/cmake/modules/AddLLVM.cmake
+++ b/llvm/cmake/modules/AddLLVM.cmake
@@ -873,6 +873,7 @@ function(export_executable_symbols target)
       set(new_libs ${newer_libs})
       set(newer_libs "")
     endwhile()
+    list(REMOVE_DUPLICATES static_libs)
     if (MSVC)
       set(mangling microsoft)
     else()