[PATCH] D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking

Tue Dec 10 23:19:32 PST 2019

uabelho added a comment.

In D70676#1777672 <https://reviews.llvm.org/D70676#1777672>, @jmorse wrote:

> D71283 <https://reviews.llvm.org/D71283> Should (TM) fix it, but, the x86 test that I wrote and which seemed to replicate the issue, now no longer replicates the issue. Which is unfortunate.
>
> Would you be able to give that patch (and its parent) a test to see whether it fixes the problem you're encountering? Storing the subregister separately should entirely fix this I believe, I'm just having problems replicating it on x86.

I tried out D71279 <https://reviews.llvm.org/D71279> and D71283 <https://reviews.llvm.org/D71283> individually and they both seem to fix the problem I saw.
I haven't done very wide testing, but the mir-reproducer I had passes. Nice!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70676/new/

https://reviews.llvm.org/D70676