[llvm] fc76569 - [ValueTracking] Add tests for non-null check after load/store; NFC
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 11 11:26:51 PST 2019
Author: Danila Kutenin
Date: 2019-12-11T20:26:31+01:00
New Revision: fc765698e0c23c18732255fc7cc0f98160b66a90
URL: https://github.com/llvm/llvm-project/commit/fc765698e0c23c18732255fc7cc0f98160b66a90
DIFF: https://github.com/llvm/llvm-project/commit/fc765698e0c23c18732255fc7cc0f98160b66a90.diff
LOG: [ValueTracking] Add tests for non-null check after load/store; NFC
Tests for D71177.
Added:
Modified:
llvm/test/Analysis/ValueTracking/known-nonnull-at.ll
Removed:
################################################################################
diff --git a/llvm/test/Analysis/ValueTracking/known-nonnull-at.ll b/llvm/test/Analysis/ValueTracking/known-nonnull-at.ll
index 00eea73ca2dc..1414f230e2b0 100644
--- a/llvm/test/Analysis/ValueTracking/known-nonnull-at.ll
+++ b/llvm/test/Analysis/ValueTracking/known-nonnull-at.ll
@@ -7,7 +7,7 @@ declare void @bar(i8* %a, i8* nonnull %b)
define i1 @caller1(i8* %x, i8* %y) {
; CHECK-LABEL: @caller1(
-; CHECK-NEXT: call void @bar(i8* %x, i8* %y)
+; CHECK-NEXT: call void @bar(i8* [[X:%.*]], i8* [[Y:%.*]])
; CHECK-NEXT: ret i1 false
;
call void @bar(i8* %x, i8* %y)
@@ -19,8 +19,8 @@ define i1 @caller1(i8* %x, i8* %y) {
define i1 @caller2(i8* %x, i8* %y) {
; CHECK-LABEL: @caller2(
-; CHECK-NEXT: call void @bar(i8* %y, i8* %x)
-; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp eq i8* %y, null
+; CHECK-NEXT: call void @bar(i8* [[Y:%.*]], i8* [[X:%.*]])
+; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp eq i8* [[Y]], null
; CHECK-NEXT: ret i1 [[NULL_CHECK]]
;
call void @bar(i8* %y, i8* %x)
@@ -32,7 +32,7 @@ define i1 @caller2(i8* %x, i8* %y) {
define i1 @caller3(i8* %x, i8* %y) {
; CHECK-LABEL: @caller3(
-; CHECK-NEXT: call void @bar(i8* %x, i8* %y)
+; CHECK-NEXT: call void @bar(i8* [[X:%.*]], i8* [[Y:%.*]])
; CHECK-NEXT: ret i1 true
;
call void @bar(i8* %x, i8* %y)
@@ -44,8 +44,8 @@ define i1 @caller3(i8* %x, i8* %y) {
define i1 @caller4(i8* %x, i8* %y) {
; CHECK-LABEL: @caller4(
-; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp ne i8* %y, null
-; CHECK-NEXT: call void @bar(i8* %x, i8* %y)
+; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp ne i8* [[Y:%.*]], null
+; CHECK-NEXT: call void @bar(i8* [[X:%.*]], i8* [[Y]])
; CHECK-NEXT: ret i1 [[NULL_CHECK]]
;
%null_check = icmp ne i8* %y, null
@@ -57,12 +57,12 @@ define i1 @caller4(i8* %x, i8* %y) {
define i1 @caller5(i8* %x, i8* %y) {
; CHECK-LABEL: @caller5(
-; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp eq i8* %y, null
-; CHECK-NEXT: br i1 [[NULL_CHECK]], label %t, label %f
+; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp eq i8* [[Y:%.*]], null
+; CHECK-NEXT: br i1 [[NULL_CHECK]], label [[T:%.*]], label [[F:%.*]]
; CHECK: t:
; CHECK-NEXT: ret i1 [[NULL_CHECK]]
; CHECK: f:
-; CHECK-NEXT: call void @bar(i8* %x, i8* %y)
+; CHECK-NEXT: call void @bar(i8* [[X:%.*]], i8* [[Y]])
; CHECK-NEXT: ret i1 [[NULL_CHECK]]
;
%null_check = icmp eq i8* %y, null
@@ -80,13 +80,17 @@ declare i32 @esfp(...)
define i1 @caller6(i8* %x, i8* %y) personality i8* bitcast (i32 (...)* @esfp to i8*){
; CHECK-LABEL: @caller6(
-; CHECK-NEXT: invoke void @bar(i8* %x, i8* nonnull %y)
-; CHECK-NEXT: to label %cont unwind label %exc
+; CHECK-NEXT: invoke void @bar(i8* [[X:%.*]], i8* nonnull [[Y:%.*]])
+; CHECK-NEXT: to label [[CONT:%.*]] unwind label [[EXC:%.*]]
; CHECK: cont:
; CHECK-NEXT: ret i1 false
+; CHECK: exc:
+; CHECK-NEXT: [[LP:%.*]] = landingpad { i8*, i32 }
+; CHECK-NEXT: filter [0 x i8*] zeroinitializer
+; CHECK-NEXT: unreachable
;
invoke void @bar(i8* %x, i8* nonnull %y)
- to label %cont unwind label %exc
+ to label %cont unwind label %exc
cont:
%null_check = icmp eq i8* %y, null
@@ -94,7 +98,7 @@ cont:
exc:
%lp = landingpad { i8*, i32 }
- filter [0 x i8*] zeroinitializer
+ filter [0 x i8*] zeroinitializer
unreachable
}
@@ -102,8 +106,9 @@ declare i8* @returningPtr(i8* returned %p)
define i1 @nonnullReturnTest(i8* nonnull %x) {
; CHECK-LABEL: @nonnullReturnTest(
-; CHECK-NEXT: %x2 = call i8* @returningPtr(i8* %x)
+; CHECK-NEXT: [[X2:%.*]] = call i8* @returningPtr(i8* [[X:%.*]])
; CHECK-NEXT: ret i1 false
+;
%x2 = call i8* @returningPtr(i8* %x)
%null_check = icmp eq i8* %x2, null
ret i1 %null_check
@@ -111,11 +116,99 @@ define i1 @nonnullReturnTest(i8* nonnull %x) {
define i1 @unknownReturnTest(i8* %x) {
; CHECK-LABEL: @unknownReturnTest(
-; CHECK-NEXT: %x2 = call i8* @returningPtr(i8* %x)
-; CHECK-NEXT: %null_check = icmp eq i8* %x2, null
-; CHECK-NEXT: ret i1 %null_check
+; CHECK-NEXT: [[X2:%.*]] = call i8* @returningPtr(i8* [[X:%.*]])
+; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp eq i8* [[X2]], null
+; CHECK-NEXT: ret i1 [[NULL_CHECK]]
+;
%x2 = call i8* @returningPtr(i8* %x)
%null_check = icmp eq i8* %x2, null
ret i1 %null_check
}
+; TODO: Make sure that if load/store happened, the pointer is nonnull.
+
+define i32 @test_null_after_store(i32* %0) {
+; CHECK-LABEL: @test_null_after_store(
+; CHECK-NEXT: store i32 123, i32* [[TMP0:%.*]], align 4
+; CHECK-NEXT: [[TMP2:%.*]] = icmp eq i32* [[TMP0]], null
+; CHECK-NEXT: [[TMP3:%.*]] = select i1 [[TMP2]], i32 1, i32 2
+; CHECK-NEXT: ret i32 [[TMP3]]
+;
+ store i32 123, i32* %0, align 4
+ %2 = icmp eq i32* %0, null
+ %3 = select i1 %2, i32 1, i32 2
+ ret i32 %3
+}
+
+define i32 @test_null_after_load(i32* %0) {
+; CHECK-LABEL: @test_null_after_load(
+; CHECK-NEXT: [[TMP2:%.*]] = load i32, i32* [[TMP0:%.*]], align 4
+; CHECK-NEXT: [[TMP3:%.*]] = icmp eq i32* [[TMP0]], null
+; CHECK-NEXT: [[TMP4:%.*]] = select i1 [[TMP3]], i32 [[TMP2]], i32 1
+; CHECK-NEXT: ret i32 [[TMP4]]
+;
+ %2 = load i32, i32* %0, align 4
+ %3 = icmp eq i32* %0, null
+ %4 = select i1 %3, i32 %2, i32 1
+ ret i32 %4
+}
+
+; Make sure that
diff erent address space does not affect null pointer check.
+
+define i32 @test_null_after_store_addrspace(i32 addrspace(1)* %0) {
+; CHECK-LABEL: @test_null_after_store_addrspace(
+; CHECK-NEXT: store i32 123, i32 addrspace(1)* [[TMP0:%.*]], align 4
+; CHECK-NEXT: [[TMP2:%.*]] = icmp eq i32 addrspace(1)* [[TMP0]], null
+; CHECK-NEXT: [[TMP3:%.*]] = select i1 [[TMP2]], i32 1, i32 2
+; CHECK-NEXT: ret i32 [[TMP3]]
+;
+ store i32 123, i32 addrspace(1)* %0, align 4
+ %2 = icmp eq i32 addrspace(1)* %0, null
+ %3 = select i1 %2, i32 1, i32 2
+ ret i32 %3
+}
+
+define i32 @test_null_after_load_addrspace(i32 addrspace(1)* %0) {
+; CHECK-LABEL: @test_null_after_load_addrspace(
+; CHECK-NEXT: [[TMP2:%.*]] = load i32, i32 addrspace(1)* [[TMP0:%.*]], align 4
+; CHECK-NEXT: [[TMP3:%.*]] = icmp eq i32 addrspace(1)* [[TMP0]], null
+; CHECK-NEXT: [[TMP4:%.*]] = select i1 [[TMP3]], i32 [[TMP2]], i32 1
+; CHECK-NEXT: ret i32 [[TMP4]]
+;
+; CHECK-NEXT ret i32 %4
+ %2 = load i32, i32 addrspace(1)* %0, align 4
+ %3 = icmp eq i32 addrspace(1)* %0, null
+ %4 = select i1 %3, i32 %2, i32 1
+ ret i32 %4
+}
+
+; Make sure if store happened after the check, nullptr check is not removed.
+
+declare i8* @func(i64)
+
+define i8* @test_load_store_after_check(i8* %0) {
+; CHECK-LABEL: @test_load_store_after_check(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[TMP1:%.*]] = call i8* @func(i64 0)
+; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp eq i8* [[TMP1]], null
+; CHECK-NEXT: br i1 [[NULL_CHECK]], label [[RETURN:%.*]], label [[IF_END:%.*]]
+; CHECK: if.end:
+; CHECK-NEXT: store i8 7, i8* [[TMP1]]
+; CHECK-NEXT: br label [[RETURN]]
+; CHECK: return:
+; CHECK-NEXT: [[RETVAL_0:%.*]] = phi i8* [ [[TMP1]], [[IF_END]] ], [ null, [[ENTRY:%.*]] ]
+; CHECK-NEXT: ret i8* [[RETVAL_0]]
+;
+entry:
+ %1 = call i8* @func(i64 0)
+ %null_check = icmp eq i8* %1, null
+ br i1 %null_check, label %return, label %if.end
+
+if.end:
+ store i8 7, i8* %1
+ br label %return
+
+return:
+ %retval.0 = phi i8* [ %1, %if.end ], [ null, %entry ]
+ ret i8* %retval.0
+}
More information about the llvm-commits
mailing list