[PATCH] D70450: [AArch64] Teach Load/Store optimizier to rename store operands for pairing.

Wed Dec 11 11:00:03 PST 2019

fhahn added a comment.

In D70450#1780195 <https://reviews.llvm.org/D70450#1780195>, @mstorsjo wrote:

> In D70450#1779903 <https://reviews.llvm.org/D70450#1779903>, @fhahn wrote:
>
> > In D70450#1779886 <https://reviews.llvm.org/D70450#1779886>, @fhahn wrote:
> >
> > > In D70450#1779756 <https://reviews.llvm.org/D70450#1779756>, @phosek wrote:
> > >
> > > > We're seeing an assertion error in Clang when compiling compiler-rt builtins for aarch64-linux-gnu with this change:
> > > >
> > > >   FAILED: CMakeFiles/clang_rt.builtins-aarch64.dir/multc3.c.o 
> > > >   /b/s/w/ir/k/recipe_cleanup/clanga0lNQB/llvm_build_dir/./bin/clang --target=aarch64-unknown-linux-gnu --sysroot=/b/s/w/ir/k/cipd/linux-arm64 -DVISIBILITY_HIDDEN  -O2 -g -DNDEBUG    -std=c11 -fPIC -fno-builtin -fvisibility=hidden -fomit-frame-pointer -MD -MT CMakeFiles/clang_rt.builtins-aarch64.dir/multc3.c.o -MF CMakeFiles/clang_rt.builtins-aarch64.dir/multc3.c.o.d -o CMakeFiles/clang_rt.builtins-aarch64.dir/multc3.c.o   -c /b/s/w/ir/k/llvm-project/compiler-rt/lib/builtins/multc3.c
> > > >   clang-10: /b/s/w/ir/k/llvm-project/llvm/include/llvm/MC/MCRegisterInfo.h:677: llvm::MCRegUnitIterator::MCRegUnitIterator(llvm::MCRegister, const llvm::MCRegisterInfo *): Assertion `Reg && "Null register has no regunits"' failed.
> > > >   clang-10: error: unable to execute command: Aborted
> > > >   clang-10: error: clang frontend command failed due to signal (use -v to see invocation)
> > > >
> > >
> > >
> > > Looks like the patch missed to skip debug operands in an assertion. I will push a fix shortly.
> >
> >
> > Should be fixed by rG4fe92abceb9a <https://reviews.llvm.org/rG4fe92abceb9a43fffc1c14a8f5150f1057020bf4>
>
>
> Still broken for me; with https://martin.st/temp/mingw_pformatw.c, built with `clang -target aarch64-w64-mingw32 -c -O2 -g`, I'm still getting the same error.

Yeah, there were some cases with non-debug $noreg operands. Fixed by rG2675a3c8806a <https://reviews.llvm.org/rG2675a3c8806a0995f204efe999db6001f6e700cf>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70450/new/

https://reviews.llvm.org/D70450