[PATCH] D70924: [Metadata] Add TBAA struct metadata to `AAMDNode`

Anton Afanasyev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 10:39:43 PST 2019


anton-afanasyev marked an inline comment as done.
anton-afanasyev added inline comments.


================
Comment at: llvm/lib/Analysis/TypeBasedAliasAnalysis.cpp:527
         MDNode::getMostGenericTBAA(N.TBAA, getMetadata(LLVMContext::MD_tbaa));
-  else
-    N.TBAA = getMetadata(LLVMContext::MD_tbaa);
-
-  if (Merge)
+    N.TBAAStruct = MDNode::getMostGenericTBAA(
+        N.TBAAStruct, getMetadata(LLVMContext::MD_tbaa_struct));
----------------
anton-afanasyev wrote:
> hfinkel wrote:
> > Does MDNode::getMostGenericTBAA actually support struct.tbaa metadata? I didn't think that it did.
> No, it really didn't. Fixing it.
Updated. I conservatively suppose that merging two `!tbaa.struct`'s turns to `MayAlias`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70924/new/

https://reviews.llvm.org/D70924





More information about the llvm-commits mailing list