[PATCH] D68863: [LNT] Python 3 support: don't assume order of cmake args

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added a comment.

Thanks for the patch @thopre ! I've got a comment above.



================
Comment at: tests/runtest/test_suite-cache.shtest:18
+# RUN: FileCheck  --check-prefix CHECK-CACHE1 < %t.cmake-cache.log %s
+# CHECK-CACHE1: Execute: {{.*}}cmake {{(.+ )?}}-DCMAKE_CXX_COMPILER:FILEPATH={{.*}}/FakeCompilers/clang++-r154331
+# RUN: FileCheck  --check-prefix CHECK-CACHE2 < %t.cmake-cache.log %s
----------------
My reading from this

```lang=python
for key in ['CMAKE_C_COMPILER:FILEPATH',                          
            'CMAKE_CXX_COMPILER:FILEPATH']:                       
    value = defs.pop(key, None)                                   
    if value is not None:                                         
        early_defs[key] = value                                   
                                                                  
cmake_cmd = ([cmake_cmd] +                                        
             ['-D%s=%s' % (k, v) for k, v in early_defs.items()] +
             cmake_flags + [self._test_suite_dir()] +             
             ['-D%s=%s' % (k, v) for k, v in defs.items()])       
```

is that we may still want to check that the compilers and the cache appear in the specific order (right after the `cmake`). 

The other ones, whose order is unpredictable, (`-DFOO=BAR`, `-DBAR=BAZ`) we do want to check them individually,

Does this make sense?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68863/new/

https://reviews.llvm.org/D68863