[PATCH] D71244: [DWARF5][DWARFVerifier] Check that Skeleton compilation unit does not have children.

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/skeleton-unit-verify.ll:3
+; RUN: llvm-dwarfdump --verify %t | FileCheck %s
+; RUN: sed 's/splitDebugInlining: false/splitDebugInlining: true/' < %s > %t2
+; RUN: llc %t2 -mtriple=x86_64-linux -filetype=obj --split-dwarf-file=test.dwo -o %t1 
----------------
aprantl wrote:
> If you really want to use sed here (I think an assembler or yaml2obj test would be more appropriate for malformed dwarf) you need to add `REQUIRES: shell`
I now agree with Adrian, a hand-coded .debug_info section in assembler would be better.  There are other tests that verify splitDebugInlining=true does the right thing.  You will want one split CU with a tag that has no children, and one with a tag that does; the verifier should detect only the one error.
The test does not need a lot of attributes in the compile_unit tags, it can be very minimal.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71244/new/

https://reviews.llvm.org/D71244