[PATCH] D71175: [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another node

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/DebugInfo/X86/sdag-transfer-dbgvalue.ll:27
+  call void @llvm.dbg.value(metadata i32 %a, metadata !14, metadata !DIExpression()), !dbg !17
+  call void @llvm.dbg.value(metadata i32* %b, metadata !15, metadata !DIExpression()), !dbg !17
+  %add = add nsw i32 %a, 512, !dbg !18
----------------
aprantl wrote:
> Do we need all three dbg.values or could we further reduce the testcase by removing all but one?
Another trick you can do is to delete all unneeded !dbg attachements or make them all point to the same location.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71175/new/

https://reviews.llvm.org/D71175