[PATCH] D70821: [SystemZ] Implement the packed stack layout
Ulrich Weigand via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 11 04:55:25 PST 2019
uweigand added a comment.
I like this much better, thanks for making that change. Just two more questions:
- Why are you calling getOrCreateFramePointerSaveIndex in determineCalleeSaves? Wouldn't it be preferable to move that to assignCalleeSavedSpillSlots? Then all the code depending on usePackedStack would be in one place -- and maybe this wouldn't even to be a seperate subroutine at all, but just a local decision in assignCalleeSavedSpillSlots.
- Maybe it would be better to move the IsVarArg code even within assignCalleeSavedSpillSlots to inside the usePackedStack block (after all, in the !usePackedStack block that code would be incorrect -- and yes, currently we never use packed stack for varargs, but that's just a limitation of the current code; in principle, it would of course be possible to do so, as GCC does as well). (But that's just a minor issue at this point and could also be addressed later.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70821/new/
https://reviews.llvm.org/D70821
More information about the llvm-commits
mailing list