[PATCH] D71274: [DebugInfo] Fix printing of DW_LNS_set_isa

Wed Dec 11 04:18:52 PST 2019

jhenderson marked 2 inline comments as done.
jhenderson added inline comments.

================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:711
+  EXPECT_TRUE(InOutput("0x0000002f: 02 DW_LNS_advance_pc (11)\n")) << Output;
+  EXPECT_TRUE(InOutput("0x00000031: 03 DW_LNS_advance_line (23)\n")) << Output;
+  EXPECT_TRUE(InOutput("0x00000033: 04 DW_LNS_set_file (33)\n")) << Output;
----------------
probinson wrote:
> Put a FIXME here? as you just filed PR44261 about this.
Done. I also had to add `OS.flush()` after the `parseNext` call as otherwise `Output` didn't contain the expected output when running on my Linux machine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71274/new/

https://reviews.llvm.org/D71274