[PATCH] D71332: Rollback assumeAligned in MemorySanitizer

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet marked 2 inline comments as done.
gchatelet added a comment.

Thx



================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2925
 
-    IRB.CreateMaskedStore(Shadow, ShadowPtr, Alignment.value(), Mask);
+    IRB.CreateMaskedStore(Shadow, ShadowPtr, Alignment ? Alignment->value() : 0,
+                          Mask);
----------------
courbet wrote:
> `getValueOr(0)` ? Here and below.
Unfortunately no, `getValueOr()` takes an `Align` which  by definition can't be  `0`.
I'll clean this up in subsequent patches by modifying `CreateMaskedStore`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71332/new/

https://reviews.llvm.org/D71332