[PATCH] D71331: [llvm-objcopy][MachO][NFC] Allow section to own its contents
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 11 03:08:49 PST 2019
jhenderson added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/MachO/Object.h:41
+ Optional<std::vector<uint8_t>> OwnedContentData;
+ StringRef Content;
+
----------------
Since you're storing the owned content as a `std::vector<uint8_t>`, it may make more sense for `Content` to be an `ArrayRef` rather than a `StringRef`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71331/new/
https://reviews.llvm.org/D71331
More information about the llvm-commits
mailing list