[PATCH] D71007: [ARM][LowOverheadLoops] Remove dead loop update instructions

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 02:11:21 PST 2019


SjoerdMeijer added a comment.

Thanks for the reviews.

> I don't see the value in splitting getInstWithUseBefore and getAllInstWithUseBefore

I thought the benefit is having these 2 primitives, as I see them both being useful. And since `getAllInstWithUseBefore` is not doing anything than just driving `getInstWithUseBefore`, I thought this was a nice abstraction. If I change my mind on this later, I will follow up on this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71007/new/

https://reviews.llvm.org/D71007





More information about the llvm-commits mailing list