[PATCH] D71323: [profile] Avoid allocating a page on the stack, NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 23:55:11 PST 2019


MaskRay added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:136
+            (sizeof(uint64_t) > BytesToWrite) ? BytesToWrite : sizeof(uint64_t);
+        if (fwrite(Zeroes, sizeof(uint8_t), PartialWriteLen, File) !=
+            PartialWriteLen) {
----------------
`sizeof(uint8_t)` -> 1 ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71323/new/

https://reviews.llvm.org/D71323





More information about the llvm-commits mailing list