[PATCH] D71069: [ELF][Hexagon]Add TPREL relocation support to Hexagon

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/hexagon-tls-tprel.s:41
+
+        .type   b, at object
+        .globl  b
----------------
MaskRay wrote:
> Don't simply copy clang output.
> 
> Directives like `.type b, at object` should be deleted. The symbol `a` `b` etc are of type `STT_TYPE`, not `STT_OBJECT`. The directives used here are just confusing.
Directives like .type b, at object should be deleted. The symbol a b etc are of type STT_TLS, not STT_OBJECT. The directives used here are just confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71069/new/

https://reviews.llvm.org/D71069