[llvm] d434563 - [LegalizeTypes] Remove manual worklist management from SoftenFloatRes_FP_EXTEND.
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 10 22:33:43 PST 2019
Author: Craig Topper
Date: 2019-12-10T22:33:31-08:00
New Revision: d4345636e678ccab8a87b09cdad9129e54c23100
URL: https://github.com/llvm/llvm-project/commit/d4345636e678ccab8a87b09cdad9129e54c23100
DIFF: https://github.com/llvm/llvm-project/commit/d4345636e678ccab8a87b09cdad9129e54c23100.diff
LOG: [LegalizeTypes] Remove manual worklist management from SoftenFloatRes_FP_EXTEND.
I think this is no longer needed. The system should take care
of legalizing any new nodes that are added. I think this might
have been needed prior to r371709 or r307053.
Added:
Modified:
llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
index 8f10c60d505e..686bdbef9a63 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
@@ -477,9 +477,6 @@ SDValue DAGTypeLegalizer::SoftenFloatRes_FP_EXTEND(SDNode *N) {
} else {
Op = DAG.getNode(ISD::FP_EXTEND, SDLoc(N), MVT::f32, Op);
}
-
- if (getTypeAction(MVT::f32) == TargetLowering::TypeSoftenFloat)
- AddToWorklist(Op.getNode());
}
if (getTypeAction(Op.getValueType()) == TargetLowering::TypePromoteFloat) {
diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
index 7a97d980f9e4..63ddb59fce68 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
@@ -204,7 +204,8 @@ bool DAGTypeLegalizer::run() {
// non-leaves.
for (SDNode &Node : DAG.allnodes()) {
if (Node.getNumOperands() == 0) {
- AddToWorklist(&Node);
+ Node.setNodeId(ReadyToProcess);
+ Worklist.push_back(&Node);
} else {
Node.setNodeId(Unanalyzed);
}
diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h b/llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h
index 42597fcd12ec..cf777540039d 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h
@@ -225,11 +225,6 @@ class LLVM_LIBRARY_VISIBILITY DAGTypeLegalizer {
void SplitInteger(SDValue Op, EVT LoVT, EVT HiVT,
SDValue &Lo, SDValue &Hi);
- void AddToWorklist(SDNode *N) {
- N->setNodeId(ReadyToProcess);
- Worklist.push_back(N);
- }
-
//===--------------------------------------------------------------------===//
// Integer Promotion Support: LegalizeIntegerTypes.cpp
//===--------------------------------------------------------------------===//
More information about the llvm-commits
mailing list