[PATCH] D71281: [LLD][ELF][AArch64][ARM] When errata patching, round thunk size to page boundary

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

Thank you for fixing the issue. This is an interesting edge case that I haven't thought about that before.



================
Comment at: lld/ELF/SyntheticSections.cpp:3364
+size_t ThunkSection::getSize() const {
+  uint64_t thunkAlign =
+      (config->fixCortexA53Errata843419 || config->fixCortexA8) ? 4096 : 1;
----------------
nit: this is perhaps my personal preference but I'd think I prefer

  if (config->fixCortexA53Errata843419 || config->fixCortexA8)
    return alignTo(size, 4096);
  return size;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71281/new/

https://reviews.llvm.org/D71281