[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 17:23:34 PST 2019


rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:759
                     Type *Ty) const;
-  int getIntImmCost(Intrinsic::ID IID, unsigned Idx, const APInt &Imm,
-                    Type *Ty) const;
+  int getIntImmCostIntrin(Intrinsic::ID IID, unsigned Idx, const APInt &Imm,
+                          Type *Ty) const;
----------------
efriedma wrote:
> For the sake of anyone downstream, it would be better to rename both overloads.
Hm, true, when I wrote this, I think I found a way to do it such that the compiler told me about all the incorrect call sites. I forget the details, though, I did it over Thanksgiving.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71320/new/

https://reviews.llvm.org/D71320





More information about the llvm-commits mailing list