[PATCH] D71285: [fuzzer] Add basic support for emscripten.

Jonathan Metzman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 18:09:52 PST 2019


metzman marked 2 inline comments as done.
metzman added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerDriver.cpp:287
+  // now.
+  if (LIBFUZZER_EMSCRIPTEN)
+    return;
----------------
hctim wrote:
> Can we hoist this into the caller - having:
> 
> ```
> if (!LIBFUZZER_EMSCRIPTEN)
>   StartRssThread(F, A);
> ```
> 
> ... seems clearer to me than silently not doing the thing the function says it does some of the time.
Done. 
Do you like the way I did it now (with an `#if` macro?) or do you want the `if ` to be code? (I guess the macro way might result in a complaint about unused function and is IMO uglier but clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71285/new/

https://reviews.llvm.org/D71285





More information about the llvm-commits mailing list