[PATCH] D71242: [LLD][ELF]{ARM][AArch64] Add missing classof to patch sections.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 10 17:51:22 PST 2019
ruiu added a comment.
classof is an LLVM's way of implementing a dynamic casting, and the code is idiomatic -- we almost always dispatch only by an enum field. So this could be a bit confusing to those who are expecting that idiomatic mechanism? I wonder if it is better to define a new function instead of overloading classof.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71242/new/
https://reviews.llvm.org/D71242
More information about the llvm-commits
mailing list