[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

[Artem Dergachev via Phabricator via llvm-commits]

NoQ added inline comments.


================
Comment at: cfe/trunk/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:295-297
+      OS << "Null pointer argument in call to " << CurrentFunctionDescription
+         << ' ' << IdxOfArg << llvm::getOrdinalSuffix(IdxOfArg)
+         << " parameter";
----------------
NoQ wrote:
> It sounds like this code remained untested because tests don't match end-of-line.
> 
> I noticed it because it produces warnings that don't look like valid English, such as:
> 
> > "Null pointer argument in call to memory set function 1st parameter"
> 
> Patches are welcome :)
D71321.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66333/new/

https://reviews.llvm.org/D66333