[PATCH] D71030: Tighten the check for Tool name ( ar, nm, dlltool, lib)

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Does sys::path::stem(ToolName) convert llvm-dlltool.exe

In D71030#1778131 <https://reviews.llvm.org/D71030#1778131>, @rupprecht wrote:

> In D71030#1769588 <https://reviews.llvm.org/D71030#1769588>, @MaskRay wrote:
>
> > Oh, I think this may break `llvm-dlltool.exe` and `llvm-ar.exe` on Windows. We probably need a more sophisticated heuristic.
>
>
> Does `sys::path::stem(ToolName)` convert `llvm-dlltool.exe` to `llvm-dlltool`? I don't have a Windows machine to check with, but it looks like it *might*.


Created D71302 <https://reviews.llvm.org/D71302>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71030/new/

https://reviews.llvm.org/D71030