[PATCH] D71285: Summary: [fuzzer] Add basic support for emscripten.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 13:51:34 PST 2019


hctim added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerDriver.cpp:287
+  // now.
+  if (LIBFUZZER_EMSCRIPTEN)
+    return;
----------------
Can we hoist this into the caller - having:

```
if (!LIBFUZZER_EMSCRIPTEN)
  StartRssThread(F, A);
```

... seems clearer to me than silently not doing the thing the function says it does some of the time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71285/new/

https://reviews.llvm.org/D71285





More information about the llvm-commits mailing list