[PATCH] D70582: [FPEnv][X86] Constrained FCmp intrinsics enabling on X86

Tue Dec 10 13:15:59 PST 2019

craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

In D70582#1777051 <https://reviews.llvm.org/D70582#1777051>, @pengfei wrote:

> In D70582#1776752 <https://reviews.llvm.org/D70582#1776752>, @uweigand wrote:
>
> > > signaling->signalling
> >
> > Not to be too nitpicky, but I've been using the US spelling (with one 'l') in the common code parts of the patch :-)  Should we be consistent here?
>
>
> I found IEEE754 uses signaling, I think it's better to follow it as well as common code.

Agreed. Sorry for the trouble.

LGTM

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70582/new/

https://reviews.llvm.org/D70582