[PATCH] D71244: [DWARF5][DWARFVerifier] Check that Skeleton compilation unit does not have children.

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3542
       Args.hasFlag(options::OPT_fsplit_dwarf_inlining,
-                   options::OPT_fno_split_dwarf_inlining, true);
+                   options::OPT_fno_split_dwarf_inlining, false);
 
----------------
dblaikie wrote:
> aprantl wrote:
> > probinson wrote:
> > > aprantl wrote:
> > > > What does this have to do with the dwarfdump patch?
> > > So that by default we emit DWARF that passes the verifier?
> > Sorry for being terse earlier. The review says this is a DWARFVerifier patch so it shouldn't touch clang. The clang part should be split into a separate commit with a different commit message.
> +1 to this needing to be separate patches (& if there's any automation that's testing that some clang compiled binary passes the verifier that this verifier change would break, then the change in clang's defaults should go in first & then the verifier change after that to ensure things aren't broken between them)
Oh, good point.  And a more explicit driver test, now that I look at it that way.


================
Comment at: clang/test/Driver/split-debug.c:82
 
-// RUN: %clang -target x86_64-unknown-linux-gnu -gsplit-dwarf -gmlt -S -### %s 2> %t
+// RUN: %clang -target x86_64-unknown-linux-gnu -gsplit-dwarf -gmlt -fsplit-dwarf-inlining -S -### %s 2> %t 
 // RUN: FileCheck -check-prefix=CHECK-GMLT-OVER-SPLIT < %t %s
----------------
There should be a test verifying that -fno-split-dwarf-inlining is the default.  Up around line 67 there's a test that passes it to the driver and then checks it gets passed to cc1; remove the option from that driver command line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71244/new/

https://reviews.llvm.org/D71244