[PATCH] D71244: [DWARF5][DWARFVerifier] Check that Skeleton compilation unit does not have children.
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 10 10:27:55 PST 2019
aprantl added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3542
Args.hasFlag(options::OPT_fsplit_dwarf_inlining,
- options::OPT_fno_split_dwarf_inlining, true);
+ options::OPT_fno_split_dwarf_inlining, false);
----------------
probinson wrote:
> aprantl wrote:
> > What does this have to do with the dwarfdump patch?
> So that by default we emit DWARF that passes the verifier?
Sorry for being terse earlier. The review says this is a DWARFVerifier patch so it shouldn't touch clang. The clang part should be split into a separate commit with a different commit message.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71244/new/
https://reviews.llvm.org/D71244
More information about the llvm-commits
mailing list