[PATCH] D71259: AMDGPU: Stop setting attributes based on TargetOptions

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

In D71259#1777733 <https://reviews.llvm.org/D71259#1777733>, @arsenm wrote:

> In D71259#1777687 <https://reviews.llvm.org/D71259#1777687>, @rampitec wrote:
>
> > In D71259#1777599 <https://reviews.llvm.org/D71259#1777599>, @arsenm wrote:
> >
> > > In D71259#1777574 <https://reviews.llvm.org/D71259#1777574>, @rampitec wrote:
> > >
> > > > > clang and lld do not call the function to do this, which they maybe should.
> > > >
> > > > Should we first fix clang then?
> > >
> > >
> > > They probably shouldn't be using these flags, but I don't know where to diagnose it either. They can properly set the function attributes themselves. The purpose of these flags is to help writing lit tests
> >
> >
> > We should somehow translate opencl options into user code. I agree these should not be set on library functions. If clang properly set attributes now then this code indeed needs to be removed.
>
>
> The user facing flags should set the function attributes. clang can propagate the attributes into the OpenCL library when linked, but we currently aren't using clang to do the linking


I do not think it really should propagate attributes into the library. LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71259/new/

https://reviews.llvm.org/D71259