[compiler-rt] 8c7d5c8 - [profile] Add explanatory comments to instrprof-darwin-exports.c, NFC

[Vedant Kumar via llvm-commits]

Author: Vedant Kumar
Date: 2019-12-10T09:45:04-08:00
New Revision: 8c7d5c8b2bcc4dc63a8cb52dddcb6bfeb7a99b23

URL: https://github.com/llvm/llvm-project/commit/8c7d5c8b2bcc4dc63a8cb52dddcb6bfeb7a99b23
DIFF: https://github.com/llvm/llvm-project/commit/8c7d5c8b2bcc4dc63a8cb52dddcb6bfeb7a99b23.diff

LOG: [profile] Add explanatory comments to instrprof-darwin-exports.c, NFC

Added: 
    

Modified: 
    compiler-rt/test/profile/instrprof-darwin-exports.c

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/profile/instrprof-darwin-exports.c b/compiler-rt/test/profile/instrprof-darwin-exports.c
index 1ef36ae8b553..5e5f69b91cb8 100644
--- a/compiler-rt/test/profile/instrprof-darwin-exports.c
+++ b/compiler-rt/test/profile/instrprof-darwin-exports.c
@@ -3,22 +3,30 @@
 // Compiling with PGO/code coverage on Darwin should raise no warnings or errors
 // when using an exports list.
 
+// 1) Check that using PGO/code coverage flags with an export list containing
+// just "_main" produces no warnings or errors.
+//
 // RUN: echo "_main" > %t.exports
 // RUN: %clang_pgogen -Werror -Wl,-exported_symbols_list,%t.exports -o %t %s 2>&1 | tee %t.log
 // RUN: %clang_profgen -Werror -fcoverage-mapping -Wl,-exported_symbols_list,%t.exports -o %t %s 2>&1 | tee -a %t.log
 // RUN: cat %t.log | count 0
 
+// 2) Ditto (1), but for GCOV.
+//
 // RUN: %clang -Werror -Wl,-exported_symbols_list,%t.exports --coverage -o %t.gcov %s | tee -a %t.gcov.log
 // RUN: cat %t.gcov.log | count 0
 
-// The default set of weak external symbols should match the set of symbols
-// exported by clang. See Darwin::addProfileRTLibs.
-
+// 3) The default set of weak external symbols should match the set of symbols
+// exported by clang. See Darwin::addProfileRTLibs. This requirement was put in
+// place to support tapi binary verification.
+//
 // RUN: %clang_pgogen -Werror -o %t.default %s
 // RUN: nm -jUg %t.default | grep -v __mh_execute_header > %t.default.exports
 // RUN: nm -jUg %t > %t.clang.exports
 // RUN: 
diff  %t.default.exports %t.clang.exports
 
+// 4) Ditto (3), but for GCOV.
+//
 // RUN: %clang -Werror --coverage -o %t.gcov.default %s
 // RUN: nm -jUg %t.gcov | grep -v __mh_execute_header > %t.gcov.exports
 // RUN: nm -jUg %t.gcov.default | grep -v __mh_execute_header > %t.gcov.default.exports