[PATCH] D71145: [InstCombine] Allow to limit the max number of iterations

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 09:41:45 PST 2019


kuhar marked an inline comment as done.
kuhar added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3579-3580
+      LLVM_DEBUG(dbgs().flush());
+      assert(Iteration <= InstCombineDefaultMaxIterations &&
+             "InstCombine stuck in an infinite loop?");
+      break;
----------------
lebedev.ri wrote:
> If i'm reading this right this will not allow passing `instcombine-max-iterations` bigger than the default
> (i.e. it will assert when the default default is reached)
Yes, that's the intention. Do you suggest an alternative behavior here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71145/new/

https://reviews.llvm.org/D71145





More information about the llvm-commits mailing list