[PATCH] D70910: [compiler-rt] Add a critical section when flushing gcov counters

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 09:32:35 PST 2019


vsk added a comment.

In D70910#1777075 <https://reviews.llvm.org/D70910#1777075>, @calixte wrote:

> @vsk: the test compiler-rt/trunk/test/profile/instrprof-darwin-exports.c was failing probably because of the missing `static` on `gcov_flush_mutex`, could you check that it's ok for you ?


That should be fine, so long as the symbol is not external it cannot be exported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70910/new/

https://reviews.llvm.org/D70910





More information about the llvm-commits mailing list