[PATCH] D71267: [OpenMPIRBuilder] Add support for generating kmpc_for_static_fini
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 10 09:23:11 PST 2019
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM, two comments (one below one inlined). For the record: Later we should not expose these low level calls but for now it makes sense to move the code like this.
Please clang format the patch, we should keep the file clang formatted from the very beginning.
================
Comment at: llvm/include/llvm/Frontend/OpenMPConstants.h:81
+/// distribute',
+/// otherwise - false.
+bool isOpenMPDistributeDirective(Directive DKind);
----------------
Nit: Can we reformat these comments, please.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71267/new/
https://reviews.llvm.org/D71267
More information about the llvm-commits
mailing list