[PATCH] D71259: AMDGPU: Stop setting attributes based on TargetOptions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 08:53:21 PST 2019


arsenm added a comment.

In D71259#1777574 <https://reviews.llvm.org/D71259#1777574>, @rampitec wrote:

> > clang and lld do not call the function to do this, which they maybe should.
>
> Should we first fix clang then?


They probably shouldn't be using these flags, but I don't know where to diagnose it either. They can properly set the function attributes themselves. The purpose of these flags is to help writing lit tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71259/new/

https://reviews.llvm.org/D71259





More information about the llvm-commits mailing list