[PATCH] D71254: llc: Change behavior of -mcpu with existing attribute

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: echristo, ahatanak, RKSimon, craig.topper.
Herald added subscribers: seiya, Petar.Avramovic, rupprecht, dexonsmith, nhaehnle, wdng, jvesely.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.
arsenm added a parent revision: D71253: llc/MIR: Fix setFunctionAttributes for MIR functions.
arsenm added a child revision: D71255: llc: Change behavior of -mattr with existing attribute.

Don't overwrite existing target-cpu attributes.

I've often found the replacement behavior annoying, and this is
inconsistent with how the fast math command line flags interact with
the function attributes.

      

Does not yet change target-features, since I think that should behave
as a concatenation.


https://reviews.llvm.org/D71254

Files:
  llvm/include/llvm/CodeGen/CommandFlags.inc
  llvm/test/CodeGen/AMDGPU/memory-legalizer-atomic-insert-end.mir
  llvm/test/CodeGen/MIR/AMDGPU/llc-target-cpu-attr-from-cmdline-ir.mir
  llvm/test/CodeGen/X86/avoid-sfb-overlaps.ll
  llvm/test/CodeGen/X86/avoid-sfb.ll
  llvm/test/CodeGen/X86/llc-override-mcpu-mattr.ll
  llvm/test/DebugInfo/COFF/inlining-files.ll
  llvm/test/DebugInfo/COFF/inlining-header.ll
  llvm/test/Other/opt-override-mcpu-mattr.ll
  llvm/test/Transforms/LoopVectorize/X86/tail_folding_and_assume_safety.ll
  llvm/test/tools/llvm-objdump/AMDGPU/source-lines.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71254.233052.patch
Type: text/x-patch
Size: 14290 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191210/ff6b1947/attachment.bin>